Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): add user feedback electron widget install instructions #9213

Merged
merged 6 commits into from
Mar 5, 2024
Merged

feat(docs): add user feedback electron widget install instructions #9213

merged 6 commits into from
Mar 5, 2024

Conversation

michellewzhang
Copy link
Member

No description provided.

@michellewzhang michellewzhang requested a review from a team February 23, 2024 00:02
@vercel Vercel
Copy link

vercel bot commented Feb 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 5:57pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Mar 5, 2024 5:57pm

@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 456 bytes ⬆️

Bundle name Size Change
sentry-docs-server 5.93MB 462 bytes ⬆️
sentry-docs-edge-server 3.47kB 0 bytes
sentry-docs-client 5.52MB 6 bytes ⬇️

@michellewzhang michellewzhang changed the title feat(docs): add user feedback electron widget install instructions [do not merge] feat(docs): add user feedback electron widget install instructions Feb 23, 2024
@lizokm
Copy link
Contributor

lizokm commented Mar 4, 2024

@michellewzhang hi there! Just a friendly reminder about this doc :)

@michellewzhang
Copy link
Member Author

@michellewzhang hi there! Just a friendly reminder about this doc :)

hey @lizokm! i believe we're still waiting for confirmation that electron does in fact work with our user feedback. relevant tickets:

after it's confirmed, i'll merge this in!

cc @billyvg @AbhiPrasad @timfish

@timfish
Copy link
Collaborator

timfish commented Mar 4, 2024

I just merged the above PR.

I'll post back here when it's in a new release!

@michellewzhang
Copy link
Member Author

I just merged the above PR.

I'll post back here when it's in a new release!

@AbhiPrasad @billyvg is this docs PR good to merge in?

@AbhiPrasad AbhiPrasad mentioned this pull request Mar 4, 2024
Closed
@AbhiPrasad
Copy link
Member

@michellewzhang we need to do a release of the Electron SDK first! getsentry/sentry-electron#834 (comment)

@AbhiPrasad
Copy link
Member

We are good to go with this PR! https://github.com/getsentry/sentry-electron/releases/tag/4.20.0

@timfish
Copy link
Collaborator

timfish commented Mar 5, 2024 •
edited
Loading

This has now been released:
https://github.com/getsentry/sentry-electron/releases/tag/4.20.0

Oh, Abhi beat me to it!

@michellewzhang michellewzhang changed the title [do not merge] feat(docs): add user feedback electron widget install instructions feat(docs): add user feedback electron widget install instructions Mar 5, 2024
@michellewzhang michellewzhang merged commit afd4519 into master Mar 5, 2024
6 checks passed
@michellewzhang michellewzhang deleted the mz/electron-uf-docs branch March 5, 2024 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@c298lee c298lee c298lee approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@ryan953 ryan953 ryan953 approved these changes

@vivianyentran vivianyentran Awaiting requested review from vivianyentran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michellewzhang @lizokm @timfish @AbhiPrasad @ryan953 @c298lee