Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support and test Sentry.sendFeedback #839

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 29, 2024

Closes #834

This PR ensures that feedback can be sent from the renderer process and adds a test to ensure the envelopes correctly get passed through the main process.

@timfish timfish marked this pull request as ready for review February 29, 2024 13:16
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that the backend will ignore any additional contexts, but will double check for you.

@billyvg
Copy link
Member

billyvg commented Feb 29, 2024

Also as a headsup, we're looking at consolidating captureUserFeedback with sendFeedback (and likely killing the latter API) for v8

@timfish
Copy link
Collaborator Author

timfish commented Feb 29, 2024

we're looking at consolidating captureUserFeedback with sendFeedback

Yep no problem, will update all these tests when it happens.

I think the main difference (in features/behaviour at least!) is that sendFeedback doesn't have a way to attach a related event id?

@billyvg
Copy link
Member

billyvg commented Feb 29, 2024

I think the main difference (in features/behaviour at least!) is that sendFeedback doesn't have a way to attach a related event id?

Yep exactly

@timfish timfish merged commit 668c03f into getsentry:master Mar 4, 2024
32 checks passed
@timfish timfish deleted the feat/user-feedback branch March 5, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test User Feedback with Electron SDK
3 participants