-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update DeviceTests to net8 #2854
Conversation
bed0abc
to
7612ef2
Compare
* Generate and upload mapping file for test app * Verify that test server recieves proguard mapping file
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2854 +/- ##
==========================================
+ Coverage 75.73% 76.40% +0.67%
==========================================
Files 357 351 -6
Lines 13466 13257 -209
Branches 2671 2645 -26
==========================================
- Hits 10198 10129 -69
+ Misses 2593 2451 -142
- Partials 675 677 +2 ☔ View full report in Codecov by Sentry. |
* update internal dependencies * roll back verify.xunit * roll back xunit.runner.visualstudio
Superseded by #3286 |
Derp.. jumped the gun |
I wonder if there's a chance we get this to work at this point? I'm concerned it might get super stale eventually |
@vaind I managed to get this going in the net9.0 branch. There were multiple things going on:
I'll close this PR then. |
thanks, much appreciated! |
This original exception seems resolved now...
Many tests currently fail with the following exception:
Which looks very similar to dotnet/runtime#93770 and that should be fixed by dotnet/runtime#94469 so I think we need to wait till that makes it to a release.
but there's a new one, which is weird because we have exactly that setting:
sentry-dotnet/Directory.Build.props
Line 100 in 7108689