Add net9.0 support #3699
Merged
Add net9.0 support #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescrosswell
commented
Oct 22, 2024
jamescrosswell
commented
Oct 22, 2024
src/Sentry/Platforms/Native/buildTransitive/Sentry.Native.targets
Outdated
Show resolved
Hide resolved
jamescrosswell
commented
Oct 22, 2024
Closed
…s and Sentry.Native.targets
bricefriha
reviewed
Oct 29, 2024
…stered.DotNet9_0.Windows.DotNet.verified.txt
bruno-garcia
approved these changes
Nov 3, 2024
| @@ -13,7 +13,9 @@ | |||
| - `Scope.Transaction` is now always stored as an `AsyncLocal` also in [Global Mode](https://docs.sentry.io/platforms/dotnet/configuration/options/#is-global-mode-enabled), to prevent auto-instrumented spans from the UI ending up parented to transactions from a background task (or vice versa). ([#3596](https://github.com/getsentry/sentry-dotnet/pull/3596)) | |||
| - Sentry's Experimental Metrics feature has been deprecated and removed from the SDK. ([#3718](https://github.com/getsentry/sentry-dotnet/pull/3718)) | |||
|
|
|||
| ## Unreleased | |||
| ### Features | |||
| - Added support for `.NET 9` (preview) ([#3699](https://github.com/getsentry/sentry-dotnet/pull/3699)) | |||
There was a problem hiding this comment.
Suggested change
| - Added support for `.NET 9` (preview) ([#3699](https://github.com/getsentry/sentry-dotnet/pull/3699)) | |
| - Added support for `.NET 9` (preview) ([#3699](https://github.com/getsentry/sentry-dotnet/pull/3699)) |
| @@ -13,6 +13,12 @@ | |||
|
|
|||
| <!-- Allow references to unsigned assemblies (like MAUI) from signed projects --> | |||
| <NoWarn>$(NoWarn);CS8002</NoWarn> | |||
|
|
|||
| <!-- We need to support old stuff. Applications should definitely address these advisory warnings though. --> | |||
| <NoWarn>$(NoWarn);NU1903</NoWarn> | |||
There was a problem hiding this comment.
Since it's a major, it's a good time to review the lowest we support and bump some a bit (not necessarily to latest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3484 (comment)
Notes for Reviewers
Mostly just a version bump, but with various domino effects:
Device Tests
IsAotCompatible = truefor net8.0+ whenFrameworkSupportsAot == true. That property has been renamed toEnableAotand we now override this and set it tofalsewhen running the android device tests.