Fix logger handler support for structured log messages #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
reviewed
Aug 7, 2024
Comment on lines
-349
to
-354
| %{report: %{reason: {reason, stacktrace}}} when is_list(stacktrace) -> | ||
| sentry_opts = Keyword.put(sentry_opts, :stacktrace, stacktrace) | ||
| capture(:message, "** (stop) " <> Exception.format_exit(reason), sentry_opts, config) | ||
|
|
||
| %{report: report_info} -> | ||
| capture(:message, inspect(report_info), sentry_opts, config) |
There was a problem hiding this comment.
We were never hitting these clauses? Did mix coveralls.html confirm that? 😮
There was a problem hiding this comment.
I think so? I mean, the whole function head can be deleted and tests still pass...
There was a problem hiding this comment.
Uh, interesting. Well, not good 😄 I suspect that maybe some of those were for older Erlang versions but your change passes on all supported Erlang/Elixir versions, so we're good to go!
whatyouhide
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STR:
Logger.error(foo: "bar")Here's my attempt on fixing this. Looks like the case statement is trying to work on both
reportandmsg. Also added a basic test as I don't believe there are any for{:report, report}clause.