update Sentry #4914
Closed
update Sentry #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, we can just revert #4862 :) |
ruslandoga
commented
Dec 17, 2024
| @@ -16,7 +16,7 @@ defmodule PlausibleWeb.EmailView do | |||
| Calendar.strftime(date, "%-d %b %Y") | |||
| end | |||
|
|
|||
| def sentry_link(trace_id, dsn \\ Sentry.Config.dsn()) do | |||
| def sentry_link(trace_id, dsn \\ Sentry.get_dsn()) do | |||
There was a problem hiding this comment.
Was Sentry.Config.dsn() ever a binary? I remember it being an opaque tuple and now it's a struct ...
Really confusing API.
ruslandoga
commented
Dec 17, 2024
| @@ -10,17 +10,6 @@ defmodule Plausible.SentryFilter do | |||
| def before_send(%{original_exception: %Plug.CSRFProtection.InvalidCSRFTokenError{}}), do: false | |||
| def before_send(%{original_exception: %Plug.Static.InvalidPathError{}}), do: false | |||
|
|
|||
| def before_send( | |||
| %{exception: [%{type: "Clickhousex.Error"}], original_exception: %{code: code}} = event | |||
There was a problem hiding this comment.
Clickhousex is gone.
|
Looks good, why did you close it? |
|
There are too many changes that I'm not sure about. I think it would be safer to revert to Sentry.LoggerBackend and handle the upgrade later. https://3.basecamp.com/5308029/buckets/29267832/card_tables/cards/8135181616 I'll open a PR with the "revert" tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates Sentry client to the latest version to take advantage of the recent Sentry.LoggerHandler improvements:
:loggerhandler getsentry/sentry-elixir#717This change would need to be tried out on staging somehow.
This PR also removes some of the workarounds that are no longer necessary like
inspect(error)