Drop Logger backends #4862
Merged
Drop Logger backends #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
ruslandoga
commented
Nov 28, 2024
| Logger.add_backend(Sentry.LoggerBackend) | ||
| :logger.add_handler(:sentry_handler, Sentry.LoggerHandler, %{ | ||
| config: %{capture_log_messages: true, level: :error} | ||
| }) |
There was a problem hiding this comment.
iex> spawn(fn -> raise "oops" end)
#PID<0.1002.0>
{"time":"2024-11-28 15:20:16.883","msg":"Process #PID<0.1002.0> raised an exception\n** (RuntimeError) oops","level":"error"}
There was a problem hiding this comment.
iex> require Logger
iex> Logger.error("oops")
{"time":"2024-11-28 15:25:24.006","msg":"oops","level":"error"}
aerosol
approved these changes
Nov 28, 2024
|
@cnkk 👋 Would you be able to merge it when you have time? I think it would be safer this way since I don't have access to Plausible's logs / Sentry / etc. and won't be able to see if anything goes wrong. |
cnkk
approved these changes
Nov 28, 2024
This was referenced Dec 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR switches from Logger backends to
:loggerhandlers.Card: https://3.basecamp.com/5308029/buckets/29267832/card_tables/cards/7610404292
Some time later, once or if there is a need for structured logging, we can also replace ExJsonFormatter with something else.
Tests
Changelog
Documentation
Dark mode