Failed to capture traces if sentry-trace header exists

[ano1404]

Platform:

• Spring -> 2.2.1.RELEASE

IDE:

• IntelliJ -> IntelliJ IDEA 2020.2.4 (Community Edition)
  Build #IC-202.8194.7, built on November 24, 2020

Build system:

• Maven -> 3.6.3

Android Gradle Plugin:

• Yes -> If yes, which version?
• No

Sentry Android Gradle Plugin:

• Yes -> If yes, which version?
• No

Proguard/R8:

• Enabled
• Disabled

Platform installed with:

• JCenter
• Bintray
• Maven Central
• Manually

The version of the SDK:
4.0.0-alpha.1

---

I have the following issue:

So if the sentry-trace header is exists it will startTransaction in this line https://github.com/getsentry/sentry-java/blob/main/sentry-spring/src/main/java/io/sentry/spring/tracing/SentryTracingFilter.java#L88.
The transactionContext only set the parentSampled in https://github.com/getsentry/sentry-java/blob/main/sentry/src/main/java/io/sentry/TransactionContext.java#L42, but does not set the sampled (set to null) https://github.com/getsentry/sentry-java/blob/main/sentry/src/main/java/io/sentry/TransactionContext.java#L40

This will lead to always skipping the capture process in https://github.com/getsentry/sentry-java/blob/main/sentry/src/main/java/io/sentry/Hub.java#L652-L658 because the transaction.isSampled() returns null

Expected result:

• Result it should capture the traces even with sentry-trace header exists

[maciejwalkowiak]

Thanks @ano1404 for reporting. Fix is on a way.

[bruno-garcia]

@ano1404 thanks a lot for trying it out and raising the issue ❤️