Fix inheriting sampling decision from parent. #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
marandaneto
reviewed
Dec 9, 2020
| val transaction = hub.startTransaction(transactionContext) | ||
| assertNotNull(transaction) | ||
| assertNotNull(transaction.isSampled) | ||
| assertTrue(transaction.isSampled!!) |
There was a problem hiding this comment.
do we need !! here? Kotlin should do it automatically for you as you did assertNotNull(transaction.isSampled) before
There was a problem hiding this comment.
we wouldn't if its immutable. But unfortunately it is mutable.
marandaneto
approved these changes
Dec 9, 2020
Codecov Report
@@ Coverage Diff @@
## main #1100 +/- ##
=========================================
Coverage 73.97% 73.97%
Complexity 1576 1576
=========================================
Files 163 163
Lines 5603 5603
Branches 570 570
=========================================
Hits 4145 4145
Misses 1171 1171
Partials 287 287
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Dec 10, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-1099
📢 Type of change
📜 Description
Fix inheriting sampling decision from parent.
💡 Motivation and Context
When transaction was created from transaction context without providing custom sampling context,
tracingSamplerwas not used.💚 How did you test it?
Unit test.
📝 Checklist
🔮 Next steps