Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: samples DSN and missing inAppIncludes #1282

Merged
merged 6 commits into from
Feb 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentry-samples/sentry-samples-console/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {
}

application {
mainClassName = "io.sentry.samples.console.Main"
mainClass.set("io.sentry.samples.console.Main")
}

configure<JavaPluginConvention> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ public static void main(String[] args) throws InterruptedException {
// UI:
options.addInAppExclude("org.jboss");

// Include frames from our package
options.addInAppInclude("io.sentry.samples");

// Performance configuration options
// Set what percentage of traces should be collected
options.setTracesSampleRate(1.0); // set 0.5 to send 50% of traces
Expand Down
2 changes: 1 addition & 1 deletion sentry-samples/sentry-samples-jul/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
}

application {
mainClassName = "io.sentry.samples.jul.Main"
mainClass.set("io.sentry.samples.jul.Main")
applicationDefaultJvmArgs = mutableListOf("-Djava.util.logging.config.file=${project.projectDir}/src/main/resources/logging.properties")
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
dsn=https://502f25099c204a2fbf4cb16edc5975d1@o447951.ingest.sentry.io/5428563
debug=true
environment=staging
in-app-includes=io.sentry.samples
2 changes: 1 addition & 1 deletion sentry-samples/sentry-samples-log4j2/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {
}

application {
mainClassName = "io.sentry.samples.log4j2.Main"
mainClass.set("io.sentry.samples.log4j2.Main")
}

configure<JavaPluginConvention> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<!-- Setting minimumBreadcrumbLevel modifies the default minimum level to add breadcrumbs from INFO to DEBUG -->
<!-- Setting minimumEventLevel the default minimum level to capture an event from ERROR to WARN -->
<Sentry name="Sentry"
dsn="https://9eda1857f9344d51821b656ba3557780@o420886.ingest.sentry.io/5339853"
dsn="https://502f25099c204a2fbf4cb16edc5975d1@o447951.ingest.sentry.io/5428563"
minimumBreadcrumbLevel="DEBUG"
minimumEventLevel="WARN"
/>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
in-app-includes="io.sentry.samples"
2 changes: 1 addition & 1 deletion sentry-samples/sentry-samples-logback/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {
}

application {
mainClassName = "io.sentry.samples.logback.Main"
mainClass.set("io.sentry.samples.logback.Main")
}

configure<JavaPluginConvention> {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
in-app-includes="io.sentry.samples"
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public void onStartup(Set<Class<?>> c, ServletContext ctx) throws ServletExcepti
// NOTE: Replace the test DSN below with YOUR OWN DSN to see the events from this app in
// your Sentry project/dashboard
options.setDsn(
"https://2ca2c945dfb7451b8136480015b2aaf6@o420886.ingest.sentry.io/5433286");
"https://502f25099c204a2fbf4cb16edc5975d1@o447951.ingest.sentry.io/5428563");

// All events get assigned to the release. See more at
// https://docs.sentry.io/workflow/releases/
Expand Down Expand Up @@ -49,6 +49,9 @@ public void onStartup(Set<Class<?>> c, ServletContext ctx) throws ServletExcepti

// Enable SDK logging with Debug level
options.setDebug(true);

// Include frames from our package
options.addInAppInclude("io.sentry.samples");
});
}
}
2 changes: 1 addition & 1 deletion sentry-samples/sentry-samples-spring-boot/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ Then, execute a command from the module directory:
Make an HTTP request that will trigger events:

```
curl -XPOST --user user:password http://localhost:8080/person/ -H "Content-Type:application/json" -d '{"firstName":"John","lastName":"Smith"}
curl -XPOST --user user:password http://localhost:8080/person/ -H "Content-Type:application/json" -d '{"firstName":"John","lastName":"Smith"}'
```
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ sentry.logging.minimum-breadcrumb-level=debug
sentry.enable-tracing=true
sentry.traces-sample-rate=1.0
sentry.debug=true
in-app-includes="io.sentry.samples"
2 changes: 1 addition & 1 deletion sentry-samples/sentry-samples-spring/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ Then, execute a command from the module directory:
Make an HTTP request that will trigger events:

```
curl -XPOST --user user:password http://localhost:8080/sentry-samples-spring/person/ -H "Content-Type:application/json" -d '{"firstName":"John","lastName":"Smith"}
curl -XPOST --user user:password http://localhost:8080/sentry-samples-spring/person/ -H "Content-Type:application/json" -d '{"firstName":"John","lastName":"Smith"}'
```
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
debug=true
in-app-includes="io.sentry.samples"