-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: samples DSN and missing inAppIncludes #1282
Conversation
sentry-samples/sentry-samples-jul/src/main/resources/sentry.properties
Outdated
Show resolved
Hide resolved
sentry-samples/sentry-samples-log4j2/src/main/resources/sentry.properties
Outdated
Show resolved
Hide resolved
sentry-samples/sentry-samples-spring/src/main/resources/sentry.properties
Outdated
Show resolved
Hide resolved
@maciejwalkowiak sentry-samples-servlet is not tested either, as there's no simple run and forget command like the others, is there a way to do like the other samples, so we can run thru Gradle instead of deploying the war file? |
sentry-samples/sentry-samples-jul/src/main/java/io/sentry/samples/jul/Main.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1282 +/- ##
=========================================
Coverage 75.64% 75.64%
Complexity 1785 1785
=========================================
Files 183 183
Lines 6207 6207
Branches 622 622
=========================================
Hits 4695 4695
Misses 1232 1232
Partials 280 280 Continue to review full report at Codecov.
|
📜 Description
Fix: samples DSN and missing inAppIncludes
Found 2 bugs #1293 and #1291
💡 Motivation and Context
#1281
💚 How did you test it?
📝 Checklist
🔮 Next steps