Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: samples DSN and missing inAppIncludes #1282

Merged
merged 6 commits into from
Feb 25, 2021
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Feb 22, 2021

📜 Description

Fix: samples DSN and missing inAppIncludes
Found 2 bugs #1293 and #1291

💡 Motivation and Context

#1281

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto
Copy link
Contributor Author

@maciejwalkowiak sentry-samples-servlet is not tested either, as there's no simple run and forget command like the others, is there a way to do like the other samples, so we can run thru Gradle instead of deploying the war file?

@codecov-io
Copy link

codecov-io commented Feb 25, 2021

Codecov Report

Merging #1282 (d39b2c7) into main (4620134) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1282   +/-   ##
=========================================
  Coverage     75.64%   75.64%           
  Complexity     1785     1785           
=========================================
  Files           183      183           
  Lines          6207     6207           
  Branches        622      622           
=========================================
  Hits           4695     4695           
  Misses         1232     1232           
  Partials        280      280           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4620134...d39b2c7. Read the comment docs.

@marandaneto marandaneto changed the title Fix samples Fix: samples DSN and missing inAppIncludes Feb 25, 2021
@marandaneto marandaneto marked this pull request as ready for review February 25, 2021 11:02
@marandaneto marandaneto merged commit 12c7ff7 into main Feb 25, 2021
@marandaneto marandaneto deleted the fix/samples-in-app branch February 25, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants