Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting in-app-includes from external properties. #1291

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Fix setting in-app-includes from external properties.

💡 Motivation and Context

https://github.com/getsentry/sentry-java/pull/1282/files#r580247477

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@codecov-io
Copy link

codecov-io commented Feb 25, 2021

Codecov Report

Merging #1291 (e2b7b2e) into main (8324e22) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1291      +/-   ##
============================================
+ Coverage     75.64%   75.65%   +0.01%     
- Complexity     1784     1785       +1     
============================================
  Files           183      183              
  Lines          6199     6207       +8     
  Branches        620      622       +2     
============================================
+ Hits           4689     4696       +7     
  Misses         1231     1231              
- Partials        279      280       +1     
Impacted Files Coverage Δ Complexity Δ
sentry/src/main/java/io/sentry/SentryOptions.java 85.66% <100.00%> (+0.39%) 124.00 <0.00> (+2.00)
...src/main/java/io/sentry/transport/RateLimiter.java 77.35% <0.00%> (-0.95%) 27.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8324e22...e2b7b2e. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants