-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ThreadLocalAccessor
for propagating Sentry hub with reactor / WebFlux
#2570
Implement ThreadLocalAccessor
for propagating Sentry hub with reactor / WebFlux
#2570
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
db5bd4e | 286.94 ms | 315.26 ms | 28.32 ms |
db5bd4e | 352.90 ms | 359.52 ms | 6.62 ms |
db5bd4e | 314.82 ms | 349.17 ms | 34.35 ms |
d691d8f | 352.56 ms | 389.59 ms | 37.03 ms |
db5bd4e | 347.00 ms | 366.74 ms | 19.74 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
db5bd4e | 1.73 MiB | 2.34 MiB | 626.30 KiB |
db5bd4e | 1.73 MiB | 2.34 MiB | 626.30 KiB |
db5bd4e | 1.73 MiB | 2.34 MiB | 626.30 KiB |
d691d8f | 1.73 MiB | 2.34 MiB | 626.23 KiB |
db5bd4e | 1.73 MiB | 2.34 MiB | 626.30 KiB |
Previous results on branch: feat/support-thread-local-accessor-for-reactor
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
05b9e20 | 343.67 ms | 366.00 ms | 22.33 ms |
b3f3d7a | 336.37 ms | 387.04 ms | 50.67 ms |
14b93a6 | 305.29 ms | 334.71 ms | 29.43 ms |
faa16e4 | 329.80 ms | 384.18 ms | 54.38 ms |
7620651 | 325.24 ms | 359.59 ms | 34.35 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
05b9e20 | 1.73 MiB | 2.34 MiB | 626.30 KiB |
b3f3d7a | 1.73 MiB | 2.34 MiB | 626.30 KiB |
14b93a6 | 1.73 MiB | 2.34 MiB | 626.30 KiB |
faa16e4 | 1.73 MiB | 2.34 MiB | 626.22 KiB |
7620651 | 1.73 MiB | 2.34 MiB | 626.30 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2570 +/- ##
============================================
- Coverage 80.42% 80.40% -0.03%
- Complexity 4006 4017 +11
============================================
Files 329 332 +3
Lines 15111 15160 +49
Branches 1978 1979 +1
============================================
+ Hits 12153 12189 +36
- Misses 2179 2191 +12
- Partials 779 780 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📜 Description
Implement
ThreadLocalAccessor
for propagating Sentry hub with reactor / WebFlux💡 Motivation and Context
To automatically have the correct thread local hub without requiring explicit user code.
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps