Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TryCatch integration #8838

Closed
Tracked by #9508
Lms24 opened this issue Aug 18, 2023 · 0 comments · Fixed by #10755
Closed
Tracked by #9508

Rename TryCatch integration #8838

Lms24 opened this issue Aug 18, 2023 · 0 comments · Fixed by #10755
Assignees
Labels
Meta: Breaking Package: browser Issues related to the Sentry Browser SDK Type: Improvement
Milestone

Comments

@Lms24
Copy link
Member

Lms24 commented Aug 18, 2023

Problem Statement

The name of our TryCatch integration is confusing as it doesn't convey what the integration actually does but it rather suggests how it does things.

For reference, the TryCatch integration instruments callbacks of timer functions (setTimeout, setInterval, etc.) to better handle errors within the timers' callbacks. It does so by wrapping them in try/catch blocks but this is an implementation detail rather than the purpose of the integration.

Solution Brainstorm

Proposed new name:

  • TimerFunctions
  • WrapTimerCallbacks

Definitely open to other ideas ;)

Note: We can backwards compatibly introduce the new named integration before directly working on v8 and deprecate the old name but we should discuss if this is worth the bundle size hit, given that it's a default integration anyway and not a lot of users will use it directly.

@Lms24 Lms24 added this to the 8.0.0 milestone Aug 18, 2023
@Lms24 Lms24 added Package: core Issues related to the Sentry Core SDK Package: browser Issues related to the Sentry Browser SDK and removed Package: core Issues related to the Sentry Core SDK labels Aug 18, 2023
@mydea mydea mentioned this issue Nov 9, 2023
@AbhiPrasad AbhiPrasad self-assigned this Feb 21, 2024
AbhiPrasad added a commit that referenced this issue Feb 21, 2024
…egration` (#10755)

Resolves #8838

- Removes `TryCatch` integration class export
- Updates angular to refer to browserApiErrorsIntegration by name
instead of using `TryCatch`
AbhiPrasad added a commit that referenced this issue Feb 21, 2024
…egration` (#10755)

Resolves #8838

- Removes `TryCatch` integration class export
- Updates angular to refer to browserApiErrorsIntegration by name
instead of using `TryCatch`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta: Breaking Package: browser Issues related to the Sentry Browser SDK Type: Improvement
Projects
None yet
2 participants