Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v8/browser): Rename TryCatch integration to browserApiErrorsIntegration #10755

Merged
merged 2 commits into from
Feb 21, 2024
Merged

feat(v8/browser): Rename TryCatch integration to browserApiErrorsIntegration #10755

merged 2 commits into from
Feb 21, 2024

Conversation

AbhiPrasad
Copy link
Member

Resolves #8838

  • Removes TryCatch integration class export
  • Updates angular to refer to browserApiErrorsIntegration by name instead of using TryCatch

@AbhiPrasad AbhiPrasad requested review from a team, stephanie-anderson and Lms24 and removed request for a team February 21, 2024 02:44
@AbhiPrasad AbhiPrasad self-assigned this Feb 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.8 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.06 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.99 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.57 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.27 KB (-0.03% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.17 KB (-0.03% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (-0.03% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.13 KB (-0.04% 🔽)
@sentry/browser - Webpack (gzipped) 22.41 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.05 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.55 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.52 KB (-0.1% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.69 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.39 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.11 KB (-0.03% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.87 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.82 KB (-0.07% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.36 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped) 22.44 KB (+0.02% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.84 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.08 KB (-0.01% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.16 KB (0%)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) February 21, 2024 13:29
@AbhiPrasad AbhiPrasad merged commit 2ea788c into develop Feb 21, 2024
92 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-browser-api-errors branch February 21, 2024 13:55
AbhiPrasad added a commit that referenced this pull request Feb 21, 2024
@AbhiPrasad
feat(v8/browser): Rename TryCatch integration to `browserApiErrorsInt…
df9c05c 
…egration` (#10755)

Resolves #8838

- Removes `TryCatch` integration class export
- Updates angular to refer to browserApiErrorsIntegration by name
instead of using `TryCatch`
1natsu172 added a commit to 1natsu172/sentry-docs that referenced this pull request Jun 26, 2024
@1natsu172
Remove deprecated integration name
0de9196 
via getsentry/sentry-javascript#10755
@1natsu172 1natsu172 mentioned this pull request Jun 26, 2024
Merged
6 tasks
@vivianyentran vivianyentran mentioned this pull request Jun 26, 2024
Closed
meisekimiu added a commit to PermanentOrg/web-app that referenced this pull request Oct 15, 2024
@meisekimiu
Use Sentry.browserApiErrorsIntegration
6342d5b 
This is the renamed version of the `TryCatchIntegration` that was
previously used.

See: getsentry/sentry-javascript#10755
meisekimiu added a commit to PermanentOrg/web-app that referenced this pull request Oct 16, 2024
@meisekimiu
Use Sentry.browserApiErrorsIntegration
5067d77 
This is the renamed version of the `TryCatchIntegration` that was
previously used.

See: getsentry/sentry-javascript#10755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea mydea approved these changes

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson stephanie-anderson was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename TryCatch integration
3 participants
@AbhiPrasad @mydea @Lms24