-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(browser): Mark stack trace from captureMessage
with attachStacktrace: true
as synthetic
#14668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is synthetic: true
used in grouping in any way? That's the only negative about adding this right now.
size-limit report 📦
|
According to develop, |
captureMessage
with attatchStackTrace: true
as syntheticcaptureMessage
with attachStacktrace: true
as synthetic
@AbhiPrasad I checked with the issues team and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Background:
Whenever the
attachStackTrace
SDK option is set to true, the SDK will create and attach a synthetic error alongside events where we couldn't extract an actual stack trace from.This PR adds the
synthetic: true
flag to themechanism
of a synthetic exception captured alongside acaptureMessage
call. Setting this property marks the exception as synthetic which, according to our develop spec, influences issue grouping.We previously did not include any
mechanism
in such exceptions, lest did we mark them as synthetic, when callingSentry.captureMessage()
. This PR fixes that.PR for server/node: #14670