Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Mark stack trace from captureMessage with attatchStackTrace: true as synthetic #14670

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 11, 2024

Analogously to #14668 for browser, this PR marks synthetic exceptions captured during a captureException() call as synthetic.

@Lms24 Lms24 force-pushed the lms/fix-core-synthetic-true-captureMessage branch from cec4c2c to 79cd503 Compare December 12, 2024 16:46
Copy link
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.28 KB - -
@sentry/browser - with treeshaking flags 21.95 KB - -
@sentry/browser (incl. Tracing) 35.79 KB - -
@sentry/browser (incl. Tracing, Replay) 73.01 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.41 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.32 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.81 KB - -
@sentry/browser (incl. Feedback) 40.03 KB - -
@sentry/browser (incl. sendFeedback) 27.89 KB - -
@sentry/browser (incl. FeedbackAsync) 32.68 KB - -
@sentry/react 25.95 KB - -
@sentry/react (incl. Tracing) 38.59 KB - -
@sentry/vue 27.49 KB - -
@sentry/vue (incl. Tracing) 37.62 KB - -
@sentry/svelte 23.45 KB - -
CDN Bundle 24.42 KB - -
CDN Bundle (incl. Tracing) 37.45 KB - -
CDN Bundle (incl. Tracing, Replay) 72.64 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 78 KB - -
CDN Bundle - uncompressed 71.72 KB - -
CDN Bundle (incl. Tracing) - uncompressed 111.03 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.1 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.31 KB - -
@sentry/nextjs (client) 38.88 KB - -
@sentry/sveltekit (client) 36.28 KB - -
@sentry/node 162.51 KB +0.01% +12 B 🔺
@sentry/node - without tracing 98.7 KB +0.02% +16 B 🔺
@sentry/aws-serverless 126.37 KB +0.01% +10 B 🔺

View base workflow run

@Lms24 Lms24 merged commit cdaf852 into develop Dec 12, 2024
157 checks passed
@Lms24 Lms24 deleted the lms/fix-core-synthetic-true-captureMessage branch December 12, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants