Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Use allowSyntheticDefaultImports for integrations to fix localforage types #3180

Closed
wants to merge 1 commit into from
Closed

ref: Use allowSyntheticDefaultImports for integrations to fix localforage types #3180

wants to merge 1 commit into from

Conversation

kamilogorek
Copy link
Contributor

Fixes #3101

@kamilogorek kamilogorek requested a review from HazAT January 18, 2021 15:26
@kamilogorek
Copy link
Contributor Author

Nvm we had it like that before #2853 and it was broken :S

@kamilogorek kamilogorek mentioned this pull request Jan 18, 2021
Closed
@kamilogorek kamilogorek deleted the localforage-type branch January 25, 2021 11:31
@mac89
Copy link
Contributor

mac89 commented Mar 2, 2021

I think this fix should work. In #2853 the real issue seems to be the inclusion of // @ts-ignore: Module '"localforage"' has no default export.. Using allowSyntheticDefaultImports makes that @ts-ignore unnecessary.

This was referenced Mar 10, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT Awaiting requested review from HazAT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamilogorek @mac89