ref: Use allowSyntheticDefaultImports for integrations to fix localforage … #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem with this solution is that it will work correctly for our builds, however, it'll push the responsibility to any TS user, requiring them to use synthetic imports as well, which is not something we want people to do. |
|
How about using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3101
Redo of #3180.
I think this fix should work. In #2853 the real issue seems to be the inclusion of // @ts-ignore: Module '"localforage"' has no default export.. Using allowSyntheticDefaultImports makes that @ts-ignore unnecessary.