fix(types): Vendor minimal type for localforage in Offline integration
#3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
localforagepackage (upon which ourOfflineintegration depends) uses commonJS-style exports. This means that in order for our SDK to build successfully, and in order for any project using both us and Typescript to build successfully, either we have to userequirein our integration or useesModuleInteropin ourtsconfig(and force our users to do the same).Since this has been an issue multiple times over, seemingly no matter which way we (or others) try to fix it*, this PR bypasses the types supplied by
localforageand uses a custom type.So, hopefully for the last time:
Fixes #2853
Fixes #2868
Fixes #3091
Fixes #3401
*See #2856, #2864, #2861, #3101, #3294, dualinventive#1, and #3403. Not to mention this PR.