Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Support Next.js v12 #4093

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Conversation

KATT
Copy link
Contributor

@KATT KATT commented Oct 27, 2021

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@AbhiPrasad
Copy link
Member

Hey @KATT, thank you for your contribution! We will merge this in once we fully validate that Next 12 works as expected with our SDK, which we are actively working on right now.

@kurniawanw0194
Copy link

There is an open issue related to Next.js v12.

Copy link

@MKrupauskas MKrupauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need this merged because it breaks npm installs

@anonymouscatcher
Copy link

Really need this one, otherwise I have to go for react version & webpack plugin...

@reintjanhoiting1
Copy link

Hi, Would it be possible to provide a timeline when sentry supports next 12? with Vercel. I fully understand that it's not as simple as changing the peerDependency version ROFL. But right now we can only remove the sentry logging since we don't know how long we have to wait.

@smeubank smeubank added this to the Next.js 12 Support milestone Nov 18, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2021

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@Belco90
Copy link

Belco90 commented Dec 9, 2021

Still waiting for this.

@iker-barriocanal iker-barriocanal changed the title fix(nextjs): allow next.js ^12.0 in peerDependencies feat(nextjs): Support Next.js v12 Dec 10, 2021
@iker-barriocanal iker-barriocanal enabled auto-merge (squash) December 10, 2021 13:10
@iker-barriocanal iker-barriocanal merged commit 4250640 into getsentry:master Dec 10, 2021
@iker-barriocanal
Copy link
Contributor

Thanks for your contribution, @KATT! This has been merged and released, and it's available in v6.16.1.

AbhiPrasad added a commit that referenced this pull request Dec 16, 2021
In #4110 we added the note as we didn't support Next 12, but now with #4093 merged, we can update this.
AbhiPrasad added a commit that referenced this pull request Dec 16, 2021
In #4110 we added the note as we didn't support Next 12, but now with #4093 merged, we can update this.
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
Co-authored-by: iker barriocanal <32816711+iker-barriocanal@users.noreply.github.com>
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
In #4110 we added the note as we didn't support Next 12, but now with #4093 merged, we can update this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants