feat(utils): Introduce rate limit helpers #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
lobsterkatie
approved these changes
Mar 4, 2022
| }; | ||
| const headers = {}; | ||
| const updatedRateLimits = updateRateLimits(rateLimits, headers); | ||
| expect(rateLimits).toStrictEqual(updatedRateLimits); |
There was a problem hiding this comment.
Suggested change
| expect(rateLimits).toStrictEqual(updatedRateLimits); | |
| expect(updatedRateLimits).toStrictEqual(rateLimits); |
Our expectation is, effectively, "the result will be correct," so I think it makes more sense to swap these. Also, I'm curious why you're using strict equal here over equal. Are you testing that they didn't get converted to strings?
There was a problem hiding this comment.
updatedRateLimits and rateLimits should be rate limits objects. I guess we don't need the undefined checks from toStrictEqual, I'll just update it
packages/utils/src/ratelimit.ts
Outdated
Comment on lines
55
to
56
| const rlHeader = headers['x-sentry-rate-limits']; | ||
| const raHeader = headers['retry-after']; |
There was a problem hiding this comment.
Suggested change
| const rlHeader = headers['x-sentry-rate-limits']; | |
| const raHeader = headers['retry-after']; | |
| const rateLimitHeader = headers['x-sentry-rate-limits']; | |
| const retryAfterHeader = headers['retry-after']; |
You know me and spelling things out... 😛
Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
AbhiPrasad
added a commit
that referenced
this pull request
Mar 14, 2022
This patch converts the browser based transport to use the ratelimit helpers introduced in #4685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #4660
As we move toward introducing a new transport API, the first step is to validate rate-limiting logic. We do this by creating a new set of functional helpers that mutate a rate limits object.
In 5 seconds I will link a PR that does this conversion in browser.
All credits to @kamilogorek as 95% of this is from
v7-dev!Resolves https://getsentry.atlassian.net/browse/WEB-660