Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(angular): Upgrade peerDependencies to Angular 16 #8035

Merged

Conversation

arjenbrandenburgh
Copy link
Contributor

With the official release on Angular 16, and no notable changes to how Sentry should work within this new version we can safely update the peerDependencies to include Angular 16.

@Lms24
Copy link
Member

Lms24 commented May 4, 2023

Hey @arjenbrandenburgh thanks for opening this PR. As it happens, I was just testing our SDK in NG16 😅
So far everything seems to be working as usual. Exciting Release, right?

One thing though: We can't bump the peer deps in @sentry/angular as it isn't compatible with Ivy and ngcc was removed in NG16. Meaning, we'll only be able to support NG16 in @sentry/angular-ivy. Would you mind making that change, then we can take your PR. I'm gonna update our Readme in the meantime to reflect this!

@Lms24 Lms24 self-assigned this May 4, 2023
packages/angular/package.json Outdated Show resolved Hide resolved
@Lms24 Lms24 changed the title chore(upgrade): upgrade peerDependencies to Angular 16 chore(angular): Upgrade peerDependencies to Angular 16 May 4, 2023
@Lms24 Lms24 changed the title chore(angular): Upgrade peerDependencies to Angular 16 chore(angular): Upgrade peerDependencies to Angular 16 May 4, 2023
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@arjenbrandenburgh
Copy link
Contributor Author

@Lms24 You are absolutely correct. Was a bit too eager. I committed your suggestion

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@Lms24 Lms24 merged commit 44eee4c into getsentry:develop May 4, 2023
billyvg pushed a commit that referenced this pull request May 5, 2023
With the official release on Angular 16, and no notable changes to how Sentry should work within this new version we can safely update the peerDependencies of `@sentry/angular-ivy` to include Angular 16. `@sentry/angular` will no longer work with NG16 and future versions.

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants