chore(angular): Clarify @sentry/angular and @sentry/angular-ivy version compatibility
#8036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
mydea and
lforst
and removed request for
a team
Lms24
commented
May 4, 2023
Lms24
changed the title
@sentry/angular and @sentry/angular-ivy version compatibility.@sentry/angular and @sentry/angular-ivy version compatibility
mydea
reviewed
May 4, 2023
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
mydea
approved these changes
May 4, 2023
billyvg
pushed a commit
that referenced
this pull request
May 5, 2023
…ersion compatibility (#8036) Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of Angular 16,
ngccwas finally removed from the framework which means that our@sentry/angularpackage is no longer compatible with this and future versions. Therefore, this PR updates the Readme to point people towards@sentry/angular-ivy.Peer dep bump is happening in #8035
IMO there's no docs change necessary, as the current Angular docs already recommend Ivy for NG12 and newer.
I tested our SDK (Ivy) with Angular 16 and everything seems to be working as expected, including route parameterization and the various component tracking features. Meaning these two PRs should be enough to support Angular 16 🚀