Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid option name #1627

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix invalid option name #1627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ Please refer to the [UPGRADE-4.0.md](UPGRADE-4.0.md) guide for a complete list o

- You need to have `ext-curl` installed to use the SDK.

- The `IgnoreErrorsIntegration` integration was removed. Use the `ignore_errors` option instead.
- The `IgnoreErrorsIntegration` integration was removed. Use the `ignore_exceptions` option instead.

```php
Sentry\init([
'ignore_exceptions' => [BadThingsHappenedException::class],
]);
```

This option performs an [`is_a`](https://www.php.net/manual/en/function.is-a.php) check now, so you can also ignore more generic exceptions.

# Features
Expand Down Expand Up @@ -57,7 +57,7 @@ Please refer to the [UPGRADE-4.0.md](UPGRADE-4.0.md) guide for a complete list o

// After
\Sentry\addBreadcrumb(
category: 'auth',
category: 'auth',
message: 'User authenticated', // optional
metadata: ['user_id' => $userId], // optional
level: Breadcrumb::LEVEL_INFO, // set by default
Expand Down Expand Up @@ -108,11 +108,11 @@ Please refer to the [UPGRADE-4.0.md](UPGRADE-4.0.md) guide for a complete list o
{

// your custom implementation

return new Response($response->getStatusCode(), $response->getHeaders(), '');
}
};

Sentry\init([
'http_client' => $httpClient,
]);
Expand All @@ -123,4 +123,4 @@ Please refer to the [UPGRADE-4.0.md](UPGRADE-4.0.md) guide for a complete list o

# Misc

- The abandoned package `php-http/message-factory` was removed.
- The abandoned package `php-http/message-factory` was removed.
6 changes: 3 additions & 3 deletions UPGRADE-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@

- Added `ext-curl` as a composer requirement.

- The `IgnoreErrorsIntegration` integration was removed. Use the `ignore_errors` option instead.
- The `IgnoreErrorsIntegration` integration was removed. Use the `ignore_exceptions` option instead.

```php
Sentry\init([
'ignore_exceptions' => [BadThingsHappenedException::class],
]);
```

This option performs an [`is_a`](https://www.php.net/manual/en/function.is-a.php) check, so you can also ignore more generic exceptions.

- Removed support for `symfony/options-resolver: ^3.4.43`.
Expand All @@ -36,7 +36,7 @@
```

- The new default value for the `trace_propagation_targets` option is now `null`. To not attach any headers to outgoing requests, using the `GuzzleTracingMiddleware`, set this option to `[]`.
- The `ignore_errors` option now performs a `is_a` check on the provided class strings.
- The `ignore_exceptions` option now performs a `is_a` check on the provided class strings.
- The `send_attempts` option was removed. You may implement a custom transport if you rely on this behaviour.
- The `enable_compression` option was removed. Use `http_compression` instead.
- The `logger` option now accepts a `Psr\Log\LoggerInterface` instance instead of `string`.
Expand Down