Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- adding option for forcing ipv4 #187

Merged
merged 2 commits into from
Jan 23, 2015
Merged

Conversation

lechbaczynski
Copy link
Contributor

Was having problem with timeout when sending message. Found that it was due to curl using ipv6.
Forcing use of ip v4 resolving like this:

  curl_setopt($curl, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4 );

near line 606-610 in Client.php, just before:

    $options = $this->get_curl_options();
    $ca_cert = $options[CURLOPT_CAINFO];
    unset($options[CURLOPT_CAINFO]);
    curl_setopt_array($curl, $options);
    curl_exec($curl);

fixed the problem. But it is more elegant to use an option for this, like:

   $client = new Raven_Client('https://.....',array('curl_ipv4'=>true));

dcramer added a commit that referenced this pull request Jan 23, 2015
- adding option for forcing ipv4
@dcramer dcramer merged commit bc21d0a into getsentry:master Jan 23, 2015
@dcramer
Copy link
Member

dcramer commented Jan 23, 2015

Thanks!

@lechbaczynski
Copy link
Contributor Author

My pleasure :)

@lechbaczynski
Copy link
Contributor Author

If I understand correctly, you also merged the latest change that sets forcing ipv4 by default.
Was it your real intention?

@dcramer
Copy link
Member

dcramer commented Jan 28, 2015

@lechbaczynski I definitely merged the entire request. Maybe we want to backout the default IPV4 change. I personally dont have a lot of experience with IPV6, so I don't have a strong opinion on the importance.

Briones pushed a commit to Briones/sentry-php that referenced this pull request Feb 20, 2020
…rt_opt

Add support for ignore_server_port sentry option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants