Do not force IPv4 protocol by default #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although I agree forcing IPv4 by default is not a good thing (we have DNS and system configs for that) what prompted you to make this change? (for reference, original PR that made this the default: #187) |
|
I see you updated the description, in that case 💯 (title sounded like sentry.io was IP agnostic which it is not) |
stayallive
approved these changes
Sep 10, 2018
stayallive
changed the title
|
Ok. Would that be a problem to merge this change first and then create Issue for the second part? |
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todays world is moving to IPv6 fast. Let's not be tied to IPv4 and let the system to choose, which protocol to use.
For networks with broken IPv6 implementation - the ability to force IPv4 only connection still remains.