Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Emit transactions, not culprits #638

Merged
merged 1 commit into from
Aug 3, 2018
Merged

[2.0] Emit transactions, not culprits #638

merged 1 commit into from
Aug 3, 2018

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Aug 3, 2018

This is a port of #601 to 2.0.

@Jean85 Jean85 added this to the Release 2.0 milestone Aug 3, 2018
@Jean85 Jean85 self-assigned this Aug 3, 2018
@Jean85 Jean85 mentioned this pull request Aug 3, 2018
Closed
11 tasks
ste93cry
ste93cry approved these changes Aug 3, 2018
View reviewed changes
Copy link
Collaborator

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, LGTM!

@ste93cry ste93cry merged commit 35c6282 into 2.0 Aug 3, 2018
@ste93cry ste93cry deleted the port-601 branch August 3, 2018 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ste93cry ste93cry ste93cry approved these changes

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

@stayallive stayallive Awaiting requested review from stayallive

Assignees

@Jean85 Jean85

Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Jean85 @ste93cry