[2.0] Emit transactions, not culprits

lib/Raven/Client.php

@@ -352,10 +352,10 @@ public function capture(array $payload)
     {
         $event = new Event($this->config);
 
-        if (isset($payload['culprit'])) {
-            $event = $event->withCulprit($payload['culprit']);
+        if (isset($payload['transaction'])) {
+            $event = $event->withTransaction($payload['transaction']);
         } else {
-            $event = $event->withCulprit($this->transactionStack->peek());
+            $event = $event->withTransaction($this->transactionStack->peek());
         }
 
         if (isset($payload['logger'])) {

lib/Raven/Event.php

@@ -45,7 +45,7 @@ final class Event implements \JsonSerializable
     /**
      * @var string the name of the transaction (or culprit) which caused this exception
      */
-    private $culprit;
+    private $transaction;
 
     /**
      * @var string The name of the server (e.g. the host name)
@@ -238,27 +238,27 @@ public function withLogger($logger)
      *
      * @return string
      */
-    public function getCulprit()
+    public function getTransaction()
     {
-        return $this->culprit;
+        return $this->transaction;
     }
 
     /**
      * Sets the name of the transaction (or culprit) which caused this
      * exception.
      *
-     * @param string $culprit The transaction name
+     * @param string $transaction The transaction name
      *
      * @return static
      */
-    public function withCulprit($culprit)
+    public function withTransaction($transaction)
     {
-        if ($culprit === $this->culprit) {
+        if ($transaction === $this->transaction) {
             return $this;
         }
 
         $new = clone $this;
-        $new->culprit = $culprit;
+        $new->transaction = $transaction;
 
         return $new;
     }
@@ -735,8 +735,8 @@ public function toArray()
             $data['logger'] = $this->logger;
         }
 
-        if (null !== $this->culprit) {
-            $data['culprit'] = $this->culprit;
+        if (null !== $this->transaction) {
+            $data['transaction'] = $this->transaction;
         }
 
         if (null !== $this->serverName) {

tests/ClientTest.php

@@ -233,7 +233,7 @@ public function testCapture()
             ->getClient();
 
         $inputData = [
-            'culprit' => 'foo bar',
+            'transaction' => 'foo bar',
             'level' => Client::LEVEL_DEBUG,
             'logger' => 'foo',
             'tags_context' => ['foo', 'bar'],
@@ -246,7 +246,7 @@ public function testCapture()
         $event = $client->getLastEvent();
 
         $this->assertEquals(str_replace('-', '', $event->getId()->toString()), $eventId);
-        $this->assertEquals($inputData['culprit'], $event->getCulprit());
+        $this->assertEquals($inputData['transaction'], $event->getTransaction());
         $this->assertEquals($inputData['level'], $event->getLevel());
         $this->assertEquals($inputData['logger'], $event->getLogger());
         $this->assertEquals($inputData['tags_context'], $event->getTagsContext());

tests/EventTest.php

@@ -181,7 +181,7 @@ public function gettersAndSettersDataProvider()
         return [
             ['level', 'info', ['level' => 'info']],
             ['logger', 'ruby', ['logger' => 'ruby']],
-            ['culprit', 'foo', ['culprit' => 'foo']],
+            ['transaction', 'foo', ['transaction' => 'foo']],
             ['serverName', 'local.host', ['server_name' => 'local.host']],
             ['release', '0.0.1', ['release' => '0.0.1']],
             ['modules', ['foo' => '0.0.1', 'bar' => '0.0.2'], ['modules' => ['foo' => '0.0.1', 'bar' => '0.0.2']]],