Do not return error id if we know we did not send the error #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
force-pushed
the
do-not-set-errorid-when-not-sending
branch
from
3ea310e to
efeda8a
Compare
stayallive
changed the title
HazAT
approved these changes
Oct 11, 2018
Jean85
approved these changes
Oct 12, 2018
|
It does not make sense to make a PR now with the upcoming changes of the unified API as most of the code will need to be refactored or moved around |
|
Doesn't matter, it's there to keep track of it. Merged or not we are going to need to take a look at it again (or not). Better to have it than not. |
|
It would make sense only if a test is added, that wouldn't need to be changed much. |
|
BTW @stayallive already did it in #671 |
|
As far as I saw in the unified API a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we know we did not sent the error to a Sentry server we should not return the error id which could like like it would have been sent.
This makes it easier to debug and easier to show an error id (or not in this case) to users or error pages. If no error was sent we should not have an ID set.
This ofcourse cannot be done when errors are stored for bulk sending.
For example: In Laravel we check if the event id is not null before showing it to the user on the 500 screen, better not show it if we are not sending it to not get error id's from users that are never sent.