[2.0] Do not return error id if we know we did not send the error #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
force-pushed
the
do-not-set-last-error-when-not-sending
branch
from
07dd350 to
2f05269
Compare
Jean85
approved these changes
Oct 12, 2018
ste93cry
requested changes
Oct 12, 2018
| @@ -237,6 +237,19 @@ public function testGetLastEvent() | |||
| $this->assertSame($lastEvent, $client->getLastEvent()); | |||
| } | |||
|
|
|||
| public function testGetLastEventEmptyIfNotSent() | |||
There was a problem hiding this comment.
Please rename testGetLastEventEmptyIfNotSent to testGetLastEventReturnsNullIfLastEventWasNotSent
|
Closing this, this is already in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we know we did not sent the error to a Sentry server we should not return the error id or keep track of that event as the last event.