Fix undefined index generated by missing function in class #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
requested changes
May 27, 2019
ste93cry
requested changes
May 27, 2019
ste93cry
requested changes
Jun 18, 2019
There was a problem hiding this comment.
Thanks to @Nuranto in getsentry/sentry-laravel#244 we finally found a way to reproduce and validate the issue which, for knowledge, is present due to XDebug modifying the stacktrace when enabled. I've left a few comments on this PR and we would be more than happy to merge it as soon as everything has been fixed 🎉
ste93cry
requested changes
Jul 3, 2019
|
I though we already merged this but I was wrong. @adnedelcu are you willing to finish the PR? |
|
@ste93cry Yes, I am willing but I have been busy relocating. I will try to do the changes tomorrow. |
ste93cry
approved these changes
Jul 31, 2019
Jean85
approved these changes
Jul 31, 2019
|
Thank you for the great patience and for your contribution of course 🎉 |
|
So sorry it took so long. |
HazAT
added a commit
that referenced
this pull request
Aug 22, 2019
* release/2.1.2: meta: Update changelog meta: Changelog 2.1.2 Skip integrations not bound to the current client and fetch their options from it (#861) Do not set the transaction attribute of the event when in CLI (#864) Added OXID eShop to the list of 3rd party integrations (#860) Fix error thrown when function name is missing in the stacktrace frame (#823) Fix sending of GZIP-compressed requests when the enable_compression option is on (#857) # Conflicts: # CHANGELOG.md # tests/ClientBuilderTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #303 for version 2.x.