Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set the transaction attribute of the event when in CLI #864

Merged

Conversation

ste93cry
Copy link
Collaborator

@ste93cry ste93cry commented Aug 9, 2019

Q A
Branch? 2.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
License MIT

This PR fixes #862 by skipping setting the transaction attribute of the event when the $_SERVER['PATH_INFO'] value is not available (e.g. in CLI).

@ste93cry ste93cry added this to the 2.1 milestone Aug 9, 2019
@ste93cry ste93cry requested a review from Jean85 August 9, 2019 13:37
@ste93cry ste93cry merged commit 19e629d into getsentry:master Aug 9, 2019
@ste93cry ste93cry deleted the fix/do-not-set-transaction-when-in-cli branch August 9, 2019 13:45
HazAT added a commit that referenced this pull request Aug 22, 2019
* release/2.1.2:
  meta: Update changelog
  meta: Changelog 2.1.2
  Skip integrations not bound to the current client and fetch their options from it (#861)
  Do not set the transaction attribute of the event when in CLI (#864)
  Added OXID eShop to the list of 3rd party integrations (#860)
  Fix error thrown when function name is missing in the stacktrace frame (#823)
  Fix sending of GZIP-compressed requests when the enable_compression option is on (#857)

# Conflicts:
#	CHANGELOG.md
#	tests/ClientBuilderTest.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different errors while tyring to drupal drush
2 participants