Add an integration to set the transaction attribute of the event #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazAT
requested changes
Aug 20, 2019
ste93cry
force-pushed
the
feature/transaction-integration
branch
2 times, most recently
from
cfa1eb7 to
58d0990
Compare
ste93cry
force-pushed
the
feature/transaction-integration
branch
from
58d0990 to
fe6f68a
Compare
Jean85
approved these changes
Sep 10, 2019
HazAT
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stemming from #864, this PR adds a new integration similar to the one present in the JS SDK for NodeJS that sets the
transactionattribute of the event. This is a much more cleaner approach than setting it into the event factory as it can be configured from the user so that if he doesn't want to report such information he won't.