Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SENTRY_SPOTLIGHT env variable support #3443

Merged
merged 10 commits into from
Aug 14, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Aug 12, 2024

Allows setting Spotlight through $SENTRY_SPOTLIGHT env variable.

Part of getsentry/spotlight#482

Allows setting Spotlight through `$SENTRY_SPOTLIGHT` env variable.
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.73%. Comparing base (4858996) to head (bb67772).

Files Patch % Lines
sentry_sdk/client.py 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3443      +/-   ##
==========================================
- Coverage   79.80%   79.73%   -0.08%     
==========================================
  Files         134      134              
  Lines       14522    14530       +8     
  Branches     3056     3059       +3     
==========================================
- Hits        11589    11585       -4     
- Misses       2097     2112      +15     
+ Partials      836      833       -3     
Files Coverage Δ
sentry_sdk/client.py 79.25% <50.00%> (-0.56%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentry_sdk/client.py Outdated Show resolved Hide resolved
@BYK
Copy link
Member Author

BYK commented Aug 13, 2024

Will add tests and then will request a re-review.

@BYK BYK requested a review from sentrivana August 13, 2024 14:15
@sentrivana sentrivana added the Trigger: tests using secrets PR code is safe; run CI label Aug 13, 2024
@github-actions github-actions bot removed the Trigger: tests using secrets PR code is safe; run CI label Aug 13, 2024
@BYK
Copy link
Member Author

BYK commented Aug 13, 2024

Finally, ready for the final round

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BYK!

@sentrivana sentrivana added the Trigger: tests using secrets PR code is safe; run CI label Aug 14, 2024
@sentrivana sentrivana enabled auto-merge (squash) August 14, 2024 08:11
@sentrivana sentrivana merged commit 269d96d into getsentry:master Aug 14, 2024
125 of 127 checks passed
@BYK BYK deleted the byk/feat/SENTRY_SPOTLIGHT branch August 14, 2024 13:04
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Allows setting Spotlight through `$SENTRY_SPOTLIGHT` env variable.

---------

Co-authored-by: Burak Yigit Kaya <bkaya21@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants