-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for $SENTRY_DEBUG and $SENTRY_SPOTLIGHT #2374
feat: Add support for $SENTRY_DEBUG and $SENTRY_SPOTLIGHT #2374
Conversation
Part of getsentry/spotlight#482. Similar to sentry-python#3443 but it also adds support for `$SENTRY_DEBUG` which was lacking in the Ruby SDK.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2374 +/- ##
===========================================
+ Coverage 78.10% 98.71% +20.61%
===========================================
Files 149 210 +61
Lines 7011 13904 +6893
===========================================
+ Hits 5476 13726 +8250
+ Misses 1535 178 -1357
|
Astonished that it only took me like 5 tries to get it right 🤣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like a couple of tests in spotlight_transport_spec.rb
but if you don't wanna figure out rspec I can also take care of that, lmk
Co-authored-by: Neel Shah <neelshah.sa@gmail.com>
Part of getsentry/spotlight#482. Similar to getsentry/sentry-python#3443 but it also adds support for
$SENTRY_DEBUG
which was lacking in the Ruby SDK.