Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for $SENTRY_DEBUG and $SENTRY_SPOTLIGHT #2374

Merged

Conversation

BYK
Copy link
Member

@BYK BYK commented Aug 15, 2024

Part of getsentry/spotlight#482. Similar to getsentry/sentry-python#3443 but it also adds support for $SENTRY_DEBUG which was lacking in the Ruby SDK.

Burak Yigit Kaya added 8 commits August 15, 2024 14:32
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (ec70677) to head (5a4f042).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2374       +/-   ##
===========================================
+ Coverage   78.10%   98.71%   +20.61%     
===========================================
  Files         149      210       +61     
  Lines        7011    13904     +6893     
===========================================
+ Hits         5476    13726     +8250     
+ Misses       1535      178     -1357     
Components Coverage Δ
sentry-ruby 99.08% <100.00%> (+43.95%) ⬆️
sentry-rails 97.43% <ø> (ø)
sentry-sidekiq 97.01% <ø> (ø)
sentry-resque 97.11% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 98.82% <100.00%> (+18.59%) ⬆️
sentry-ruby/lib/sentry/utils/env_helper.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/configuration_spec.rb 100.00% <100.00%> (ø)

... and 126 files with indirect coverage changes

@BYK
Copy link
Member Author

BYK commented Aug 15, 2024

Astonished that it only took me like 5 tries to get it right 🤣

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like a couple of tests in spotlight_transport_spec.rb but if you don't wanna figure out rspec I can also take care of that, lmk

sentry-ruby/lib/sentry/utils/env_helper.rb Outdated Show resolved Hide resolved
@BYK BYK requested a review from sl0thentr0py August 16, 2024 15:36
@sl0thentr0py sl0thentr0py merged commit 22f2a3a into getsentry:master Aug 16, 2024
125 checks passed
@BYK BYK deleted the byk/feat/SENTRY_DEBUG_and_SENTRY_SPOTLIGHT branch August 16, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants