-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_breadcrumbs #3788
Fix test_breadcrumbs #3788
Conversation
attributes[SentrySpanAttribute.OP] = op | ||
attributes[SentrySpanAttribute.SOURCE] = source | ||
if op is not None: | ||
attributes[SentrySpanAttribute.OP] = op |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throws
Invalid type NoneType for attribute 'sentry.op' value. Expected one of ['bool', 'str', 'bytes', 'int', 'float'] or a sequence of those types
if none
@@ -37,41 +36,25 @@ def test_breadcrumbs(sentry_init, capture_events): | |||
message="breadcrumb2", **add_breadcrumbs_kwargs | |||
) | |||
|
|||
# Spans that create breadcrumbs automatically | |||
with sentry_sdk.start_span(name="span3", op=OP.DB_REDIS) as span3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these were outdated @antonpirker since we don't auto-create breadcrumbs from spans now
❌ 1198 Tests Failed:
View the top 1 failed tests by shortest run time
View the full list of 2 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
No description provided.