Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_breadcrumbs #3788

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

sl0thentr0py
Copy link
Member

No description provided.

attributes[SentrySpanAttribute.OP] = op
attributes[SentrySpanAttribute.SOURCE] = source
if op is not None:
attributes[SentrySpanAttribute.OP] = op
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throws

Invalid type NoneType for attribute 'sentry.op' value. Expected one of ['bool', 'str', 'bytes', 'int', 'float'] or a sequence of those types

if none

@@ -37,41 +36,25 @@ def test_breadcrumbs(sentry_init, capture_events):
message="breadcrumb2", **add_breadcrumbs_kwargs
)

# Spans that create breadcrumbs automatically
with sentry_sdk.start_span(name="span3", op=OP.DB_REDIS) as span3:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were outdated @antonpirker since we don't auto-create breadcrumbs from spans now

Copy link

codecov bot commented Nov 15, 2024

❌ 1198 Tests Failed:

Tests completed Failed Passed Skipped
19893 1198 18695 4413
View the top 1 failed tests by shortest run time
tests.test_scope test_with_isolation_scope
Stack Traces | 0.001s run time
tests/test_scope.py:357: in test_with_isolation_scope
    assert scope is in_with_isolation_scope
E   assert <PotelScope id=0x7ff743596c60 name=None type=ScopeType.ISOLATION> is <Scope id=0x7ff7458c02e0 name=None type=ScopeType.ISOLATION>
View the full list of 2 ❄️ flaky tests
tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.19% (Passed 2 times, Failed 246 times)

Stack Traces | 0.001s run time
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }
tests.test_scope test_with_new_scope

Flake rate in main: 96.76% (Passed 9 times, Failed 269 times)

Stack Traces | 0.001s run time
tests/test_scope.py:587: in test_with_new_scope
    assert scope is in_with_current_scope
E   assert <PotelScope id=0x7ff62c483130 name=None type=ScopeType.CURRENT> is <Scope id=0x7ff62c56e740 name=None type=ScopeType.CURRENT>

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@sl0thentr0py sl0thentr0py merged commit 238492d into potel-base Nov 18, 2024
43 of 116 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/fix-test-breadcrumbs branch November 18, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant