Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grpc aio method handling #3873

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

sl0thentr0py
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 16, 2024

❌ 130 Tests Failed:

Tests completed Failed Passed Skipped
4392 130 4262 1047
View the top 3 failed tests by shortest run time
 tests.integrations.quart.test_quart
Stack Traces | 0s run time
No failure message available
tests.integrations.arq.test_arq test_job_retry[init_arq]
Stack Traces | 0.063s run time
.../integrations/arq/test_arq.py:180: in test_job_retry
    assert event["contexts"]["trace"]["status"] == "aborted"
E   AssertionError: assert 'ok' == 'aborted'
E     - aborted
E     + ok
tests.integrations.arq.test_arq test_job_retry[init_arq_with_dict_settings]
Stack Traces | 0.063s run time
.../integrations/arq/test_arq.py:180: in test_job_retry
    assert event["contexts"]["trace"]["status"] == "aborted"
E   AssertionError: assert 'ok' == 'aborted'
E     - aborted
E     + ok

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sl0thentr0py sl0thentr0py merged commit 9d20ffd into potel-base Dec 16, 2024
82 of 125 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/fix-grpc-aio branch December 16, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants