Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grpc aio method handling #3873

Merged
merged 1 commit into from
Dec 16, 2024

Fix grpc aio method handling

17a2f48
Select commit
Loading
Failed to load commit list.
Merged

Fix grpc aio method handling #3873

Fix grpc aio method handling
17a2f48
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 16, 2024 in 0s

29.72% (-50.59%) compared to bb9e34e

View this Pull Request on Codecov

29.72% (-50.59%) compared to bb9e34e

Details

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.72%. Comparing base (bb9e34e) to head (17a2f48).

Files with missing lines Patch % Lines
sentry_sdk/integrations/grpc/aio/client.py 50.00% 0 Missing and 2 partials ⚠️
sentry_sdk/integrations/rust_tracing.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (bb9e34e) and HEAD (17a2f48). Click for more details.

HEAD has 100 uploads less than BASE
Flag BASE (bb9e34e) HEAD (17a2f48)
102 2
Additional details and impacted files
@@               Coverage Diff               @@
##           potel-base    #3873       +/-   ##
===============================================
- Coverage       80.30%   29.72%   -50.59%     
===============================================
  Files             139      139               
  Lines           14573    14577        +4     
  Branches         2308     2172      -136     
===============================================
- Hits            11703     4333     -7370     
- Misses           2156     9846     +7690     
+ Partials          714      398      -316     
Files with missing lines Coverage Δ
sentry_sdk/integrations/rust_tracing.py 0.00% <0.00%> (-83.34%) ⬇️
sentry_sdk/integrations/grpc/aio/client.py 85.00% <50.00%> (-9.45%) ⬇️

... and 113 files with indirect coverage changes