-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update JavaScript SDK to v8.39.0 #4293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
Pull requests that update a dependency file
label
Nov 20, 2024
github-actions
bot
requested review from
krystofwoldrich,
lucas-zimerman and
antonis
as code owners
November 20, 2024 03:14
bruno-garcia
force-pushed
the
deps/scripts/update-javascript.sh
branch
from
November 20, 2024 03:15
ffeef0b
to
49cdc5c
Compare
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5446992 | 403.40 ms | 426.70 ms | 23.30 ms |
700cbf4 | 425.56 ms | 436.26 ms | 10.70 ms |
15c80ab+dirty | 336.27 ms | 350.58 ms | 14.31 ms |
8ae23a7 | 526.83 ms | 513.38 ms | -13.45 ms |
12427f4 | 393.69 ms | 414.84 ms | 21.14 ms |
e1ea4a8 | 506.82 ms | 510.48 ms | 3.66 ms |
e5c9b8b | 409.02 ms | 426.66 ms | 17.64 ms |
5571a20 | 410.55 ms | 441.06 ms | 30.51 ms |
fe13591 | 478.92 ms | 480.84 ms | 1.92 ms |
9c48b2c | 349.24 ms | 385.96 ms | 36.72 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5446992 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
700cbf4 | 17.73 MiB | 20.07 MiB | 2.33 MiB |
15c80ab+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
8ae23a7 | 17.74 MiB | 20.07 MiB | 2.34 MiB |
12427f4 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
e1ea4a8 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
e5c9b8b | 17.73 MiB | 19.83 MiB | 2.10 MiB |
5571a20 | 17.73 MiB | 19.93 MiB | 2.19 MiB |
fe13591 | 17.74 MiB | 20.07 MiB | 2.34 MiB |
9c48b2c | 17.73 MiB | 19.80 MiB | 2.07 MiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7871424 | 462.63 ms | 445.80 ms | -16.83 ms |
1e9894e | 431.94 ms | 445.06 ms | 13.12 ms |
c0332a6 | 461.40 ms | 456.00 ms | -5.40 ms |
cdeca8b | 438.11 ms | 436.48 ms | -1.63 ms |
e4c23be | 452.76 ms | 438.16 ms | -14.60 ms |
d3ef7b9 | 486.60 ms | 474.76 ms | -11.84 ms |
bca5c58 | 498.31 ms | 498.32 ms | 0.01 ms |
4a9de34 | 423.00 ms | 429.66 ms | 6.66 ms |
f193e90 | 432.83 ms | 433.10 ms | 0.27 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7871424 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
1e9894e | 17.74 MiB | 20.08 MiB | 2.34 MiB |
c0332a6 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
cdeca8b | 17.74 MiB | 20.07 MiB | 2.34 MiB |
e4c23be | 17.74 MiB | 20.08 MiB | 2.34 MiB |
d3ef7b9 | 17.74 MiB | 20.08 MiB | 2.35 MiB |
bca5c58 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
4a9de34 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
f193e90 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7fd512a+dirty | 439.69 ms | 503.71 ms | 64.01 ms |
0d3e677+dirty | 384.24 ms | 431.45 ms | 47.21 ms |
15c80ab+dirty | 276.38 ms | 327.54 ms | 51.17 ms |
0db0c72+dirty | 335.20 ms | 351.06 ms | 15.86 ms |
e2b64fe+dirty | 258.82 ms | 304.26 ms | 45.44 ms |
1c65324+dirty | 381.10 ms | 427.26 ms | 46.16 ms |
5a22220+dirty | 384.61 ms | 419.06 ms | 34.45 ms |
728164b+dirty | 335.93 ms | 342.94 ms | 7.01 ms |
62a750b+dirty | 370.78 ms | 376.73 ms | 5.96 ms |
c398f67+dirty | 315.08 ms | 345.60 ms | 30.52 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7fd512a+dirty | 7.15 MiB | 8.35 MiB | 1.21 MiB |
0d3e677+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
15c80ab+dirty | 7.15 MiB | 8.09 MiB | 966.13 KiB |
0db0c72+dirty | 7.15 MiB | 8.04 MiB | 911.02 KiB |
e2b64fe+dirty | 7.15 MiB | 8.07 MiB | 947.16 KiB |
1c65324+dirty | 7.15 MiB | 8.22 MiB | 1.07 MiB |
5a22220+dirty | 7.15 MiB | 8.21 MiB | 1.06 MiB |
728164b+dirty | 7.15 MiB | 8.12 MiB | 997.71 KiB |
62a750b+dirty | 7.15 MiB | 8.21 MiB | 1.06 MiB |
c398f67+dirty | 7.15 MiB | 8.21 MiB | 1.07 MiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cdeca8b+dirty | 418.09 ms | 468.62 ms | 50.53 ms |
e4c23be+dirty | 379.09 ms | 412.68 ms | 33.59 ms |
d3ef7b9+dirty | 388.12 ms | 435.53 ms | 47.41 ms |
7871424+dirty | 417.35 ms | 468.16 ms | 50.81 ms |
f193e90+dirty | 370.91 ms | 498.10 ms | 127.19 ms |
c0332a6+dirty | 389.21 ms | 449.39 ms | 60.17 ms |
bca5c58+dirty | 369.19 ms | 401.90 ms | 32.71 ms |
4a9de34+dirty | 385.19 ms | 429.35 ms | 44.16 ms |
1e9894e+dirty | 385.63 ms | 420.18 ms | 34.55 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cdeca8b+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
e4c23be+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
d3ef7b9+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
7871424+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
f193e90+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
c0332a6+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
bca5c58+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
4a9de34+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
1e9894e+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77680ec+dirty | 1231.81 ms | 1238.35 ms | 6.54 ms |
1faf8e3+dirty | 1214.87 ms | 1222.83 ms | 7.97 ms |
7bc4d75+dirty | 1233.40 ms | 1229.56 ms | -3.83 ms |
d7401ac+dirty | 1252.38 ms | 1275.04 ms | 22.66 ms |
8ae23a7+dirty | 1230.02 ms | 1227.62 ms | -2.40 ms |
5a22220+dirty | 1209.49 ms | 1220.94 ms | 11.45 ms |
80b2ce3+dirty | 1265.92 ms | 1268.60 ms | 2.69 ms |
b95b8af+dirty | 1221.39 ms | 1228.52 ms | 7.13 ms |
d0bf494+dirty | 1289.40 ms | 1298.40 ms | 9.00 ms |
f06c879+dirty | 1252.64 ms | 1259.66 ms | 7.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77680ec+dirty | 2.36 MiB | 3.10 MiB | 753.42 KiB |
1faf8e3+dirty | 2.36 MiB | 3.08 MiB | 736.75 KiB |
7bc4d75+dirty | 2.36 MiB | 3.10 MiB | 752.58 KiB |
d7401ac+dirty | 2.36 MiB | 2.83 MiB | 481.14 KiB |
8ae23a7+dirty | 2.36 MiB | 3.10 MiB | 752.42 KiB |
5a22220+dirty | 2.36 MiB | 2.92 MiB | 570.21 KiB |
80b2ce3+dirty | 2.36 MiB | 2.84 MiB | 486.98 KiB |
b95b8af+dirty | 2.36 MiB | 3.14 MiB | 793.32 KiB |
d0bf494+dirty | 2.36 MiB | 2.83 MiB | 481.15 KiB |
f06c879+dirty | 2.36 MiB | 2.88 MiB | 530.42 KiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e4c23be+dirty | 1225.25 ms | 1223.76 ms | -1.49 ms |
4a9de34+dirty | 1215.58 ms | 1218.76 ms | 3.17 ms |
c0332a6+dirty | 1223.13 ms | 1232.31 ms | 9.18 ms |
7871424+dirty | 1212.69 ms | 1224.40 ms | 11.72 ms |
1e9894e+dirty | 1213.33 ms | 1225.16 ms | 11.83 ms |
f193e90+dirty | 1224.20 ms | 1229.10 ms | 4.90 ms |
cdeca8b+dirty | 1212.42 ms | 1223.69 ms | 11.27 ms |
bca5c58+dirty | 1208.27 ms | 1212.41 ms | 4.14 ms |
d3ef7b9+dirty | 1232.10 ms | 1230.35 ms | -1.76 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e4c23be+dirty | 2.36 MiB | 3.08 MiB | 737.17 KiB |
4a9de34+dirty | 2.36 MiB | 3.10 MiB | 753.19 KiB |
c0332a6+dirty | 2.36 MiB | 3.08 MiB | 736.57 KiB |
7871424+dirty | 2.36 MiB | 3.10 MiB | 752.86 KiB |
1e9894e+dirty | 2.36 MiB | 3.10 MiB | 752.76 KiB |
f193e90+dirty | 2.36 MiB | 3.08 MiB | 737.28 KiB |
cdeca8b+dirty | 2.36 MiB | 3.09 MiB | 743.02 KiB |
bca5c58+dirty | 2.36 MiB | 3.10 MiB | 752.95 KiB |
d3ef7b9+dirty | 2.36 MiB | 3.10 MiB | 753.53 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77680ec+dirty | 1237.65 ms | 1236.24 ms | -1.41 ms |
1faf8e3+dirty | 1223.38 ms | 1220.56 ms | -2.82 ms |
7bc4d75+dirty | 1222.13 ms | 1216.39 ms | -5.74 ms |
d7401ac+dirty | 1288.10 ms | 1289.54 ms | 1.44 ms |
8ae23a7+dirty | 1233.67 ms | 1229.52 ms | -4.15 ms |
5a22220+dirty | 1246.18 ms | 1249.61 ms | 3.43 ms |
80b2ce3+dirty | 1245.12 ms | 1262.04 ms | 16.92 ms |
b95b8af+dirty | 1235.60 ms | 1242.06 ms | 6.46 ms |
d0bf494+dirty | 1266.20 ms | 1267.52 ms | 1.32 ms |
f06c879+dirty | 1285.14 ms | 1285.86 ms | 0.72 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77680ec+dirty | 2.92 MiB | 3.66 MiB | 758.54 KiB |
1faf8e3+dirty | 2.92 MiB | 3.64 MiB | 742.61 KiB |
7bc4d75+dirty | 2.92 MiB | 3.66 MiB | 757.15 KiB |
d7401ac+dirty | 2.92 MiB | 3.40 MiB | 488.06 KiB |
8ae23a7+dirty | 2.92 MiB | 3.66 MiB | 757.67 KiB |
5a22220+dirty | 2.92 MiB | 3.48 MiB | 575.81 KiB |
80b2ce3+dirty | 2.92 MiB | 3.40 MiB | 492.75 KiB |
b95b8af+dirty | 2.92 MiB | 3.69 MiB | 794.16 KiB |
d0bf494+dirty | 2.92 MiB | 3.40 MiB | 488.08 KiB |
f06c879+dirty | 2.92 MiB | 3.44 MiB | 533.24 KiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e4c23be+dirty | 1232.21 ms | 1230.16 ms | -2.05 ms |
4a9de34+dirty | 1234.35 ms | 1230.35 ms | -3.99 ms |
c0332a6+dirty | 1227.13 ms | 1230.90 ms | 3.77 ms |
7871424+dirty | 1245.73 ms | 1235.39 ms | -10.35 ms |
1e9894e+dirty | 1233.37 ms | 1226.96 ms | -6.41 ms |
f193e90+dirty | 1228.43 ms | 1229.02 ms | 0.59 ms |
cdeca8b+dirty | 1235.78 ms | 1225.23 ms | -10.55 ms |
bca5c58+dirty | 1224.23 ms | 1224.90 ms | 0.66 ms |
d3ef7b9+dirty | 1228.35 ms | 1231.06 ms | 2.72 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e4c23be+dirty | 2.92 MiB | 3.64 MiB | 742.98 KiB |
4a9de34+dirty | 2.92 MiB | 3.66 MiB | 757.67 KiB |
c0332a6+dirty | 2.92 MiB | 3.64 MiB | 742.47 KiB |
7871424+dirty | 2.92 MiB | 3.66 MiB | 757.21 KiB |
1e9894e+dirty | 2.92 MiB | 3.66 MiB | 757.26 KiB |
f193e90+dirty | 2.92 MiB | 3.64 MiB | 742.92 KiB |
cdeca8b+dirty | 2.92 MiB | 3.64 MiB | 744.52 KiB |
bca5c58+dirty | 2.92 MiB | 3.66 MiB | 757.55 KiB |
d3ef7b9+dirty | 2.92 MiB | 3.66 MiB | 758.76 KiB |
We need to investigate why the following two tests are failing:
|
9 tasks
Opened a separate PR fixing the tests to avoid interfering with the dependency updater Github action #4294 |
bruno-garcia
force-pushed
the
deps/scripts/update-javascript.sh
branch
4 times, most recently
from
November 21, 2024 03:14
af33f3e
to
7a5b973
Compare
bruno-garcia
force-pushed
the
deps/scripts/update-javascript.sh
branch
from
November 21, 2024 09:33
7a5b973
to
652045e
Compare
antonis
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps scripts/update-javascript.sh from 8.38.0 to 8.39.0.
Auto-generated by a dependency updater.
Changelog
8.39.0
Important Changes
The
sentry/nestjs
SDK will now capture performance data for NestJS Events (nestjs/event-emitter
)Other Changes
SentryExceptionCaptured
forWithSentry
(#14322)SentryService
behaviour intosentry/nestjs
SDKinit()
(#14321)SentryGlobalFilter
(#14320)childProcessIntegration
forprocessThreadBreadcrumbIntegration
and deprecate it (#14334)_sentryModuleMetadata
is not mangled (#14344)sentry.source
attribute tocustom
when callingspan.updateName
onSentrySpan
(#14251)Request
type in favor ofRequestEventData
(#14317)transaction
inrequestDataIntegration
(#14306)