Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event's message get/set methods for desktop #510

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

tustanivsky
Copy link
Collaborator

This PR fixes an issue where the beforeSend handler returned an empty message string for events created with sentry_value_new_message_event. It ensures that the actual message string is included in the formatted child node of the message object for these events.

Closes #504

@tustanivsky tustanivsky requested a review from bitsandfoxes March 5, 2024 11:27
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Stefan Jandl <reg@bitfox.at>
@tustanivsky tustanivsky merged commit 9f47f91 into main Mar 5, 2024
9 of 10 checks passed
@tustanivsky tustanivsky deleted the fix/message-before-send branch March 5, 2024 18:22
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Fix event's message get/set methods for desktop ([#510](https://github.com/getsentry/sentry-unreal/pull/510))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 210dd30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentryBeforeSendHandler receives empty event message when using USentrySubsystem::CaptureMessage
2 participants