Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event's message get/set methods for desktop #510

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Fix event's message get/set methods for desktop #510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3c23ac
Fix event's message get/set methods for desktop
tustanivsky Mar 5, 2024
28e6527
Update changelog
tustanivsky Mar 5, 2024
210dd30
Update CHANGELOG.md
tustanivsky Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,33 +13,22 @@

- Fix Linux intermediates paths in `FilterPlugin.ini` ([#468](https://github.com/getsentry/sentry-unreal/pull/468))
- Fix casing for include of HAL/PlatformFileManager for Linux compilation ([#468](https://github.com/getsentry/sentry-unreal/pull/499))
- The message in events in the `SentryBeforeSendHandler` are no longer missing their message ([#510](https://github.com/getsentry/sentry-unreal/pull/510))

### Dependencies

- Bump Cocoa SDK (iOS) from v8.17.1 to v8.18.0 ([#467](https://github.com/getsentry/sentry-unreal/pull/467), [#474](https://github.com/getsentry/sentry-unreal/pull/474))
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8180)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.17.1...8.18.0)
- Bump Java SDK (Android) from v7.0.0 to v7.2.0 ([#469](https://github.com/getsentry/sentry-unreal/pull/469), [#481](https://github.com/getsentry/sentry-unreal/pull/481))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#720)
- Bump Cocoa SDK (iOS) from v8.17.1 to v8.20.0 ([#467](https://github.com/getsentry/sentry-unreal/pull/467), [#474](https://github.com/getsentry/sentry-unreal/pull/474), [#487](https://github.com/getsentry/sentry-unreal/pull/487), [#492](https://github.com/getsentry/sentry-unreal/pull/492))
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8200)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.17.1...8.20.0)
- Bump Java SDK (Android) from v7.0.0 to v7.4.0 ([#469](https://github.com/getsentry/sentry-unreal/pull/469), [#481](https://github.com/getsentry/sentry-unreal/pull/481), [#491](https://github.com/getsentry/sentry-unreal/pull/491), [#501](https://github.com/getsentry/sentry-unreal/pull/501))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#740)
- [diff](https://github.com/getsentry/sentry-java/compare/7.0.0...7.2.0)
- Bump CLI from v2.23.0 to v2.29.1 ([#471](https://github.com/getsentry/sentry-unreal/pull/471), [#472](https://github.com/getsentry/sentry-unreal/pull/472), [#475](https://github.com/getsentry/sentry-unreal/pull/475), [#477](https://github.com/getsentry/sentry-unreal/pull/477), [#484](https://github.com/getsentry/sentry-unreal/pull/484), [#485](https://github.com/getsentry/sentry-unreal/pull/485), [#486](https://github.com/getsentry/sentry-unreal/pull/486), [#490](https://github.com/getsentry/sentry-unreal/pull/490), [#493](https://github.com/getsentry/sentry-unreal/pull/493), [#494](https://github.com/getsentry/sentry-unreal/pull/494), [#495](https://github.com/getsentry/sentry-unreal/pull/495), [#507](https://github.com/getsentry/sentry-unreal/pull/507))
- [changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md#2291)
- [diff](https://github.com/getsentry/sentry-cli/compare/2.23.0...2.29.1)
- Bump Native SDK from v0.6.7 to v0.7.0 ([#478](https://github.com/getsentry/sentry-unreal/pull/478))
- [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#070)
- [diff](https://github.com/getsentry/sentry-native/compare/0.6.7...0.7.0)
- Bump Cocoa SDK (iOS) from v8.18.0 to v8.19.0 ([#487](https://github.com/getsentry/sentry-unreal/pull/487))
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8190)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.18.0...8.19.0)
- Bump Java SDK (Android) from v7.2.0 to v7.3.0 ([#491](https://github.com/getsentry/sentry-unreal/pull/491))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#730)
- [diff](https://github.com/getsentry/sentry-java/compare/7.2.0...7.3.0)
- Bump Cocoa SDK (iOS) from v8.19.0 to v8.20.0 ([#492](https://github.com/getsentry/sentry-unreal/pull/492))
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8200)
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.19.0...8.20.0)
- Bump Java SDK (Android) from v7.3.0 to v7.4.0 ([#501](https://github.com/getsentry/sentry-unreal/pull/501))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#740)
- [diff](https://github.com/getsentry/sentry-java/compare/7.3.0...7.4.0)

## 0.15.1

Expand Down
7 changes: 5 additions & 2 deletions plugin-dev/Source/Sentry/Private/Desktop/SentryEventDesktop.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,15 @@ sentry_value_t SentryEventDesktop::GetNativeObject()

void SentryEventDesktop::SetMessage(const FString& message)
{
sentry_value_set_by_key(EventDesktop, "message", sentry_value_new_string(TCHAR_TO_ANSI(*message)));
sentry_value_t messageСontainer = sentry_value_new_object();
sentry_value_set_by_key(messageСontainer, "formatted", sentry_value_new_string(TCHAR_TO_ANSI(*message)));
sentry_value_set_by_key(EventDesktop, "message", messageСontainer);
}

FString SentryEventDesktop::GetMessage() const
{
sentry_value_t message = sentry_value_get_by_key(EventDesktop, "message");
sentry_value_t messageСontainer = sentry_value_get_by_key(EventDesktop, "message");
sentry_value_t message = sentry_value_get_by_key(messageСontainer, "formatted");
return FString(sentry_value_as_string(message));
}

Expand Down
Loading