Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show <IconImage/> on feedback list if there is a screenshot #67795

Closed
Tracked by #64671
michellewzhang opened this issue Mar 27, 2024 · 0 comments · Fixed by #70109
Closed
Tracked by #64671

Show <IconImage/> on feedback list if there is a screenshot #67795

michellewzhang opened this issue Mar 27, 2024 · 0 comments · Fixed by #70109
Assignees
@michellewzhang

Comments

@michellewzhang
Copy link
Member

michellewzhang commented Mar 27, 2024 •
edited
Loading

We can't do this immediately because the attachments live on the feedback event. However, on the list (left side where we render the icons), we only have access to the feedback issue. So we don't know right now whether there are screenshots or not.

Possible solutions to this would be:

  • [backend] add a flag on the issue to indicate whether any/latest event has attachments
  • [backend] add the latest event ID to the feedback issue
  • [backend] add the attachments to the issue
  • [frontend] do an additional API call to fetch the latest event from the feedback item
@michellewzhang michellewzhang mentioned this issue Mar 27, 2024
Closed
This was referenced May 1, 2024
Merged
Merged
@michellewzhang michellewzhang self-assigned this May 2, 2024
michellewzhang added a commit that referenced this issue May 2, 2024
@michellewzhang
feat(issues/feedback): allow hasAttachments to be expanded for feedba…
7f2ff4c 
…ck usecase (#70102)

relates to #67795

allow expansion of a new flag on an issue, `hasAttachments`, which will
specify whether a group has any event attachments. we'll use this in
user feedback to show a indicator when a feedback has an attachment
(e.g. screenshot).

context: the user feedback list shows small icon indicators when certain
properties are true (e.g. `hasReplay`, `hasLinkedError`) and we want to
add another one to this list: `hasAttachments` (aka `hasScreenshots`).
however, the list relies on having issue data only. we don't have access
to the attachments list just from the issue (we'd have to do a separate
api call on the frontend to get the list of attachments which is
unideal), so instead i'm adding an option to expand and directly put the
`hasAttachments` property onto the issue when requested.

frontend changes using this PR are here:
#70109
michellewzhang added a commit that referenced this issue May 3, 2024
@michellewzhang
feat(feedback): show IconImage on feedback list if it has a screenshot (
abfe531 
#70109)

closes #67795
follow up to #70102 (the backend
changes)

<img width="672" alt="SCR-20240501-oexu"
src="https://github.com/getsentry/sentry/assets/56095982/3984ab3d-c919-4891-b6c9-439066525907">
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellewzhang michellewzhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(feedback): show IconImage on feedback list if it has a screenshot getsentry/sentry
1 participant
@michellewzhang