feat(feedback): show IconImage on feedback list if it has a screenshot #70109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
approved these changes
May 1, 2024
michellewzhang
added a commit
that referenced
this pull request
May 2, 2024
…ck usecase (#70102) relates to #67795 allow expansion of a new flag on an issue, `hasAttachments`, which will specify whether a group has any event attachments. we'll use this in user feedback to show a indicator when a feedback has an attachment (e.g. screenshot). context: the user feedback list shows small icon indicators when certain properties are true (e.g. `hasReplay`, `hasLinkedError`) and we want to add another one to this list: `hasAttachments` (aka `hasScreenshots`). however, the list relies on having issue data only. we don't have access to the attachments list just from the issue (we'd have to do a separate api call on the frontend to get the list of attachments which is unideal), so instead i'm adding an option to expand and directly put the `hasAttachments` property onto the issue when requested. frontend changes using this PR are here: #70109
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #67795
follow up to #70102 (the backend changes)