Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inbound-filters): Add UI toggle for ChunkLoadError inbound filter #57278

Merged
merged 10 commits into from
Oct 4, 2023

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Oct 2, 2023

This PR adds the frontend UI toggle for the new ChunkUploadError inbound filter introduced in this PR (#57277).

Closes #57131

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@iambriccardo iambriccardo changed the base branch from master to riccardo/feat/chunk-load-error-ibf October 2, 2023 12:23
@iambriccardo iambriccardo changed the title riccardo/feat/add ibf frontend feat(inbound-filters): Add UI toggle for ChunkLoadError inbound filter Oct 2, 2023
@iambriccardo iambriccardo marked this pull request as ready for review October 2, 2023 12:30
Copy link
Member

@ArthurKnaus ArthurKnaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce! 👍

@iambriccardo
Copy link
Member Author

This PR has also been closed since a new approach has been taken in (#57343), which requires a different frontend implementation.

@iambriccardo iambriccardo changed the title feat(inbound-filters): Add UI toggle for ChunkLoadError inbound filter feat(inbound-filters): Add UI toggle for ChunkLoadError inbound filter (OLD) Oct 3, 2023
@iambriccardo iambriccardo reopened this Oct 3, 2023
@iambriccardo iambriccardo changed the title feat(inbound-filters): Add UI toggle for ChunkLoadError inbound filter (OLD) feat(inbound-filters): Add UI toggle for ChunkLoadError inbound filter Oct 3, 2023
@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 2:10pm

Base automatically changed from riccardo/feat/chunk-load-error-ibf to master October 4, 2023 05:45
@iambriccardo iambriccardo requested a review from a team as a code owner October 4, 2023 05:45
@iambriccardo iambriccardo requested a review from a team October 4, 2023 05:45
@iambriccardo iambriccardo merged commit a095a76 into master Oct 4, 2023
40 checks passed
@iambriccardo iambriccardo deleted the riccardo/feat/add-ibf-frontend branch October 4, 2023 07:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inbound Filter: Chunk Load Error
3 participants