feat(inbound-filters): Add inbound filter for ChunkLoadError (OLD) #57343
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
Scope: Backend
Codecov Report
@@ Coverage Diff @@
## master #57343 +/- ##
==========================================
- Coverage 78.92% 78.92% -0.01%
==========================================
Files 5116 5116
Lines 220751 220761 +10
Branches 37377 37380 +3
==========================================
+ Hits 174225 174228 +3
- Misses 40895 40905 +10
+ Partials 5631 5628 -3
|
| if settings is not None and settings.get("isEnabled", True): | ||
| filter_settings[filter_id] = settings | ||
| # In order to support the new declarative mechanism for inbound filters also for error messages filters | ||
| # we have to handle differently the settings, since each filter will still bind to the same key. | ||
| if (messages := settings.get("errorMessages")) is not None: | ||
| error_messages += messages | ||
| else: | ||
| filter_settings[filter_id] = settings |
There was a problem hiding this comment.
Let's discuss about this.
Would be nice if we could attribute which error message comes from which filter ( on Relay side)
There was a problem hiding this comment.
Honestly, my implementation is not the best since it's hacky, I would prefer to design from first principles an integration of inbound filters that map to error messages or to top-level filters.
| # option was changed by the request | ||
| assert project.get_option("filters:chunk-load-error") == "1" | ||
|
|
||
| project.update_option("filters:chunk-load-error", "1") |
There was a problem hiding this comment.
If the option is set to a value, do we need to update it to the same value?
There was a problem hiding this comment.
It was just to clearly show that we set it to 1 and not leverage the state left by the previous execution but yeah, that could be removed.
iambriccardo
changed the title
This PR implements a new inbound filter for
ChunkLoadErrors in the form:Such inbound filter idea emerged in vercel/next.js#38507.
Closes #57131