Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: use generic Chunk interface in CallTreesReadJob #554

Merged
merged 2 commits into from
Jan 22, 2025
Merged

ref: use generic Chunk interface in CallTreesReadJob #554

merged 2 commits into from
Jan 22, 2025

Conversation

viglia
Copy link
Contributor

@viglia viglia commented Jan 21, 2025

CallTreesReadJob was still using sample specific struct to deserialize the chunk.

With this we're going to use a Chunk interface and supporting AndroidChunk as well.

@viglia viglia requested a review from a team as a code owner January 21, 2025 15:58
@viglia viglia merged commit 50cee75 into main Jan 22, 2025
12 checks passed
@viglia viglia deleted the viglia/ref/make-call_trees_read_job-use-generic-chunk branch January 22, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viglia @Zylphrex