Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: use generic Chunk interface in CallTreesReadJob #554

Merged
merged 2 commits into from
Jan 22, 2025
Merged

ref: use generic Chunk interface in CallTreesReadJob #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed3cc71
use generic Chunk interface in CallTreesReadJob
viglia Jan 21, 2025
b844314
update changelog
viglia Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
- Handle profile chunks in regressed endpoint. ([#527](https://github.com/getsentry/vroom/pull/527))
- Authentication support for Kafka connection. ([#530](https://github.com/getsentry/vroom/pull/530))
- Add support for android chunks. ([#540](https://github.com/getsentry/vroom/pull/540))
- Use generic Chunk interface in CallTreesReadJob ([#554](https://github.com/getsentry/vroom/pull/554))

**Bug Fixes**:

Expand Down
4 changes: 2 additions & 2 deletions internal/chunk/sample_readjob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ type (
CallTreesReadJobResult struct {
Err error
CallTrees map[string][]*nodetree.Node
Chunk *SampleChunk
Chunk *Chunk
TransactionID string
ThreadID *string
Start uint64
Expand All @@ -72,7 +72,7 @@ type (
)

func (job CallTreesReadJob) Read() {
var chunk SampleChunk
var chunk Chunk

err := storageutil.UnmarshalCompressed(
job.Ctx,
Expand Down
6 changes: 3 additions & 3 deletions internal/flamegraph/flamegraph.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,9 +476,9 @@ func GetFlamegraphFromCandidates(
}

example := utils.NewExampleFromProfilerChunk(
result.Chunk.ProjectID,
result.Chunk.ProfilerID,
result.Chunk.ID,
result.Chunk.GetProjectID(),
result.Chunk.GetProfilerID(),
result.Chunk.GetID(),
result.TransactionID,
&threadID,
result.Start,
Expand Down
Loading