Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error span reported on the declaration of a variable instead of its use #2089

Closed
kvark opened this issue Oct 18, 2022 · 0 comments · Fixed by #2075
Closed

Error span reported on the declaration of a variable instead of its use #2089

kvark opened this issue Oct 18, 2022 · 0 comments · Fixed by #2075
Labels
area: front-end Input formats for conversion kind: diagnostics Error message should be better lang: WGSL WebGPU shading language

Comments

@kvark
Copy link
Member

kvark commented Oct 18, 2022

Testcase

@group(0) @binding(1)
var mip_dst: texture_storage_3d<r32uint, write>;

var<workgroup> result: u32;

@compute
@workgroup_size(1)
fn main() {
	textureStore(mip_dst, vec3<i32>(0), result);
}

Error:

error:
┌─ test.wgsl:4:4

4 │ var result: u32;
│ ^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [5]
Entry point main at Compute is invalid:
The value [5] can not be stored

It's totally unclear from the error that the problem is in textureStore.

@JCapucho JCapucho added lang: WGSL WebGPU shading language area: front-end Input formats for conversion kind: diagnostics Error message should be better labels Oct 21, 2022
jimblandy added a commit to SparkyPotato/naga that referenced this issue Jan 12, 2023
Fixes gfx-rs#1745: Support out-of-order module scope declarations in WGSL
Fixes gfx-rs#1044: Forbid local variable shadowing in WGSL
Fixes gfx-rs#2076: [wgsl-in] no error for duplicated type definition
Fixes gfx-rs#2071: Global item does not support 'const'
Fixes gfx-rs#2105: [wgsl-in] Type aliases for a vecN<T> doesn't work when constructing vec from a single argument
Fixes gfx-rs#1775: Referencing a function without a return type yields an unknown identifier error.
Fixes gfx-rs#2089: Error span reported on the declaration of a variable instead of its use
Fixes gfx-rs#1996: [wgsl-in] Confusing error: "expected unsigned/signed integer literal, found '1'"

Separate parsing from lowering by generating an AST, which desugars as
much as possible down to something like Naga IR. The AST is then used
to resolve identifiers while lowering to Naga IR.

Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
Co-authored-by: Jim Blandy <jimb@red-bean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: front-end Input formats for conversion kind: diagnostics Error message should be better lang: WGSL WebGPU shading language
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants