Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve detection and validation of cubemap views #2331

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Improve detection and validation of cubemap views #2331

merged 1 commit into from
Dec 30, 2021

Conversation

kvark
Copy link
Member

@kvark kvark commented Dec 30, 2021 •
edited
Loading

Connections
Loosely connected to gpuweb/gpuweb#2463
Fixes #2323

Description
Vulkan doesn't allow cubemaps to be multisampled. So here we are doing 2 things:

  1. adding relevant validation to the view creation
  2. reducing the set of cases where we tell Vulkan to support cubemaps

Testing
Untested

@kvark kvark requested a review from cwfitzgerald December 30, 2021 00:37
cwfitzgerald
cwfitzgerald approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit but otherwise g2g

wgpu-core/src/device/mod.rs Outdated Show resolved Hide resolved
@kvark kvark enabled auto-merge (rebase) December 30, 2021 16:25
@kvark kvark merged commit a1251dc into gfx-rs:master Dec 30, 2021
@kvark kvark deleted the cube branch January 30, 2022 18:03
@kvark kvark mentioned this pull request Jan 30, 2022
Closed
cwfitzgerald pushed a commit that referenced this pull request Oct 25, 2023
@jimblandy @teoxoy
[msl-out] Revert af4d989 since #764 removes the need for it (#2331)
59a2441 
Assigning arrays by value works fine since all arrays are now wrapped by a struct.

Co-authored-by: teoxoy <28601907+teoxoy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating TextureDimension::D1 depth/stencil formats makes metal panic (and does not fail)
2 participants
@kvark @cwfitzgerald